Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces OAuth2 section with self-hosted test instructions #20928

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Jun 3, 2024

Description

This PR temporarily removes the OAuth2 section of the readme and adds instructions for testing with a self-hosted site. The reason for this change is that the introduction of Passkey support and the related WordPress.com API changes have broken the WordPress.com OAuth2 Authentication flow in the apps.

Internal ref: pbArwn-6qJ-p2


To Test:

Check the README


Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 3, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20928-01ab55f
Commit01ab55f
Direct Downloadjetpack-prototype-build-pr20928-01ab55f.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 3, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20928-01ab55f
Commit01ab55f
Direct Downloadwordpress-prototype-build-pr20928-01ab55f.apk
Note: Google Login is not supported on these builds.

@antonis antonis marked this pull request as ready for review June 3, 2024 09:03
@antonis antonis requested a review from irfano June 3, 2024 09:11
@antonis antonis added this to the 25.1 milestone Jun 3, 2024
Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we should mention that the WP login will be temporarily unavailable. But, most features are already available with self-hosted sites, so it seems fine not to mention it. You can merge after considering my np comment. Thank you for taking care of this.

README.md Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@antonis
Copy link
Contributor Author

antonis commented Jun 3, 2024

Thank you for the prompt review @irfano 🙇

I was wondering if we should mention that the WP login will be temporarily unavailable.

Good point 👍
I was undecided about including this. Thinking of it again I agree that it would help to avoid confusion and added a note with 01ab55f

@antonis antonis enabled auto-merge June 3, 2024 10:59
@antonis antonis merged commit 0e05482 into trunk Jun 3, 2024
19 of 20 checks passed
@antonis antonis deleted the task/removed-wpcom-oauth-section branch June 3, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants