Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the circular avatar to a rounded corner avatar. #20934

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

jarvislin
Copy link
Contributor

@jarvislin jarvislin commented Jun 4, 2024

See p1717167632890949/1717101371.395049-slack-C0180B5PRJ4

This is a UI update of site switcher.

Updated UI:


To Test:

  1. Sign in JP app
  2. Click on the v icon at the top-right corner to open the site switcher
  3. Those blavatars should be displayed with rounded corners
  4. Done, thank you!

Regression Notes

  1. Potential unintended areas of impact

    • site switcher
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • manual
  3. What automated tests I added (or what prevented me from doing so)

    • n/a

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 4, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20934-1aae7f9
Commit1aae7f9
Direct Downloadjetpack-prototype-build-pr20934-1aae7f9.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 4, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20934-1aae7f9
Commit1aae7f9
Direct Downloadwordpress-prototype-build-pr20934-1aae7f9.apk
Note: Google Login is not supported on these builds.

Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jarvislin jarvislin added this to the 25.1 milestone Jun 4, 2024
@jarvislin jarvislin marked this pull request as ready for review June 4, 2024 15:48
@jarvislin jarvislin requested a review from antonis June 4, 2024 15:51
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this @jarvislin 🙇
The code changes look good and the app looks as expected 🎉

@antonis antonis merged commit dc94e3e into trunk Jun 5, 2024
22 checks passed
@antonis antonis deleted the issue/site-switcher-corner branch June 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants