Remove maximum number of posts that can be loaded in ReaderPostAdapter

[RenanLukas]

Fixes #19811

sometimes posts are loaded above the last post (shifting content around)

I wasn't able to reproduce this part. I suspect it was fixed by this PR.

eventually posts stop loading.

By removing the mCanRequestMorePostsTemp logic (originally implemented in this PR) the unfollowed tag post list loaded a few more items, but eventually it stops. I thought it was something in the client, but this also happens in web which makes me think it's something in the back-end that eventually stops sending us more items.

---

To Test:

See the issue

---

Regression Notes

1. Potential unintended areas of impact

   • None

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • Manual testing

3. What automated tests I added (or what prevented me from doing so)

   • UI changes only

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

Testing Checklist (strike-out the not-applying and unnecessary ones):

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20958-cb7260b
	Commit	cb7260b
	Direct Download	jetpack-prototype-build-pr20958-cb7260b.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20958-cb7260b
	Commit	cb7260b
	Direct Download	wordpress-prototype-build-pr20958-cb7260b.apk

Note: Google Login is not supported on these builds.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[thomashorta]

I believe most of the issues from the original GH issue were previously fixed thanks to your work on using dates instead of strings as well as some other minor changes we did throughout past Reader projects, so removing this limit should make sure we have an infinite list of posts as long as the user keeps scrolling and there are posts available in that feed. 🙇🏼

That said, I still think there's some issue going on on mobile, check the rest of this comment below:

I thought it was something in the client, but this also happens in web which makes me think it's something in the back-end that eventually stops sending us more items.

Not sure which tag you used, but could you have reached the last post from the tag you were testing?

I tested with a calm tag and on Mobile (with your changes) and I can't get past the post in the screenshot below. I opened the App Inspector and noticed in the DB that the date_published field looks pretty weird (2024-05-12T11:00:07-125:56). Look at the timezone segment. App inspector screenshot also below.

As mentioned in the original issue (#19811) for tag/topic feed, the field used for the before query parameter is date_published because of the logic here. So this could be causing the issue, though I'm not sure what the proper fix is.

App Last Post for calm tag/topic feed:

App Inspector (last post highlighted):

On the Web I was able to get past it. Note that it looked stuck for a bit when I reached that same post, but after I scrolled up and down again, the posts loaded below it as expected. Also notice that the web says "Invalid Date" for the post date.

[thomashorta]

Look at my previous comment, I ended up sending it without the Code Review, but it has all the information about what I investigated with your changes.

I think the changes as-is have value, removing this unnecessary soft-limit that exists on the Android Client, but there is still some issue going on related to fetching by date, though it does look like an issue in the data retrieved by the backend, so I'm not sure what we can do from a client-side. Maybe we can try to figure out what the web does, since in the web they seem to have some workaround that "invalid date" issue (see #20958 (comment)).

[RenanLukas]

Thanks for the review and investigation, @thomashorta !

I agree this PR provides some value by removing the maximum number of posts to be loaded but it doesn't fully address the problem. Since it seems like the web is doing a workaround for invalid data returned by the back-end and we'll need to understand what they're doing, I propose we merge this PR and create a new issue/update the existing issue including your investigation. WDYT?

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[nbradbury]

This was previously approved and tested fine after updating with trunk