Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #20854 from wordpress-mobile/andy/target-s… #20964

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

notandyvee
Copy link
Contributor

@notandyvee notandyvee commented Jun 10, 2024

This PR reverts targeting SDK 34 (20854) while we investigate the play store declaration blocker.


To Test:

  • 🚬 test the app. Ensure you can login, post, use the reader, read comments.

Regression Notes

  1. Potential unintended areas of impact

    I don't expect this to be an issue. It worked prior.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    Manual test.

  3. What automated tests I added (or what prevented me from doing so)

    N/A


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…dk-34"

This reverts commit 56f0686, reversing
changes made to 0e05482.
@notandyvee notandyvee added this to the 25.1 ❄️ milestone Jun 10, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.1 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@aditi-bhatia aditi-bhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoketested and lgtm 👍

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20964-5dfcf98
Commit5dfcf98
Direct Downloadwordpress-prototype-build-pr20964-5dfcf98.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20964-5dfcf98
Commit5dfcf98
Direct Downloadjetpack-prototype-build-pr20964-5dfcf98.apk
Note: Google Login is not supported on these builds.

@notandyvee notandyvee merged commit 0be1c3d into release/25.1 Jun 10, 2024
21 of 22 checks passed
@notandyvee notandyvee deleted the andy/target-sdk-revert branch June 10, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants