AddCategoryFragment.java to AddCategoryFragment.kt
#20980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neeldoshii
changed the title
add category fragmentAddCategoryFragment.java to AddCategoryFragment.kt
|
|
@irfano -- Ready for review. |
irfano
requested changes
Jun 17, 2024
WordPress/src/main/java/org/wordpress/android/ui/posts/AddCategoryFragment.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/posts/AddCategoryFragment.kt
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| @Suppress("Deprecation") |
There was a problem hiding this comment.
We shouldn't add any new @Suppress when migrating to Kotlin. You can use Bundle.getSerializableCompat() for getSerializable(). Check usages of it in other Kotlin classes.
There was a problem hiding this comment.
Fixed in the latest commit 👍
WordPress/src/main/java/org/wordpress/android/ui/posts/AddCategoryFragment.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/posts/AddCategoryFragment.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/posts/AddCategoryFragment.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/posts/AddCategoryFragment.kt
Outdated
Show resolved
Hide resolved
Co-Authored-By: Irfan Ömür <2471769+irfano@users.noreply.github.com>
irfano
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to convert
AddCategoryFragment.javatoAddCategoryFragment.kt.Fixes/Related
Screenshots/ Video
addcategorykt.mp4
Steps to reproduce
CollapseFullScreenDialogFragmentis reproduced 🥇PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):