-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Voice to Content] Update waveform #20981
Conversation
…ording update interval.
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20981 +/- ##
==========================================
- Coverage 40.75% 40.75% -0.01%
==========================================
Files 1528 1528
Lines 70158 70165 +7
Branches 11603 11607 +4
==========================================
- Hits 28596 28595 -1
- Misses 38972 38980 +8
Partials 2590 2590 ☔ View full report in Codecov by Sentry. |
Design feedback:
|
Thank you for the feedback - I'll make note of these items and address them when I polish the UI (which will be done separately after I get all the pieces working). |
Closes https://github.com/Automattic/wordpress-mobile/issues/83
This PR updates the waveform composable
In addition to the waveform - the bottom sheet is scrollable on landscape
Note
The following have not yet been implemented
recording timer
orientation changes
landscape view
Overall polishing of the UI
Launch Edit Post
To Test:
voice-to-content
feature flag and restart the app (option is in the more menu of the debug settings view)Test Waveform
Post from audio
option to launch the Post From Audio bottom sheetTest scroll on landscape
Post from audio
option to launch the Post From Audio bottom sheetNOTE: Orientation change will in process is not handled at the moment
Regression Notes
Potential unintended areas of impact
The waveform doesn't work and the sheet is not scrollable in landscape
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones): N/A