-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Voice to Content] Launch edit post with AI content #20992
Conversation
…ice to content request
… unneeded comments
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20992 +/- ##
==========================================
- Coverage 40.74% 40.74% -0.01%
==========================================
Files 1528 1529 +1
Lines 70194 70201 +7
Branches 11612 11613 +1
==========================================
- Hits 28603 28600 -3
- Misses 39001 39011 +10
Partials 2590 2590 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I add a self-hosted site without logging in with a WP.com account, I see this screen. You can address this in another PR, but let's not forget to hide the button for self-hosted sites.
- I am supposed to see "Edit Post" after a successful recording session, right? I can't see it.
record-issue.webm
@irfano - The edit post is fixed - I caught that and fixed it in a future PR, I added it in 2758f22. |
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/voicetocontent/VoiceToContentDialogFragment.kt
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project. LGTM! 👍🏻
Closes https://github.com/Automattic/wordpress-mobile/issues/78
This PR launches the editPost view after successful recording of audio.
This branch build upon issue/v2c-show-elapsed-time
Important
Merge Instructions
- Make sure #20983 & #20984 have been merged to trunk- Remove the Not Ready for Merge LabelNote
The following have not yet been implemented:
To Test:
Regression Notes
Potential unintended areas of impact
The recorded content is not shown
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones): N/A