Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix Checkstyle configuration #21035

Closed
wants to merge 1 commit into from

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jul 8, 2024

Update configuration to address the following warning:

The Checkstyle rules file could not be parsed. cannot initialize module TreeWalker - TreeWalker is not allowed as a parent of LineLength Please review 'Parent Module' section for this Check in web documentation if Check is standard. The file has been blocked for 60s.

To Test:

N/A, no user-facing changes.

Regression Notes

  1. Potential unintended areas of impact
    CI failures.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Verify CI tasks succeed.
  3. What automated tests I added (or what prevented me from doing so)
    N/A, no user-facing changes.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Update configuration to address the following warning:

```
The Checkstyle rules file could not be parsed. cannot initialize module TreeWalker - TreeWalker is not allowed as a parent of LineLength Please review 'Parent Module' section for this Check in web documentation if Check is standard. The file has been blocked for 60s.
```
@dcalhoun dcalhoun self-assigned this Jul 8, 2024
Copy link

sonarcloud bot commented Jul 8, 2024

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21035-47f7baa
Commit47f7baa
Direct Downloadwordpress-prototype-build-pr21035-47f7baa.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21035-47f7baa
Commit47f7baa
Direct Downloadjetpack-prototype-build-pr21035-47f7baa.apk
Note: Google Login is not supported on these builds.

@dcalhoun dcalhoun marked this pull request as ready for review July 9, 2024 14:26
@dcalhoun dcalhoun closed this Jul 9, 2024
@dcalhoun dcalhoun deleted the ci/fix-checkstyle-configuration branch July 9, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants