Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update FluxC reference to trunk #21048

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jul 10, 2024

Avoid references that do not belong to the trunk branch as customary for the project.

To Test:

N/A, covered in #21036.

Regression Notes

  1. Potential unintended areas of impact
    N/A, covered in fix: Update published post date #21036.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A, covered in fix: Update published post date #21036.
  3. What automated tests I added (or what prevented me from doing so)
    N/A, covered in fix: Update published post date #21036.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Avoid references that do not belong to the trunk branch.
@dcalhoun dcalhoun self-assigned this Jul 10, 2024
Copy link

sonarcloud bot commented Jul 10, 2024

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused some dependency changes (expand to see details)

-+--- org.wordpress:fluxc:{strictly 3045-5fc175e4780dec098cfd04bf5eb9da7f3cce4076} -> 3045-5fc175e4780dec098cfd04bf5eb9da7f3cce4076
-|    +--- org.wordpress:wellsql:2.0.0
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:3045-5fc175e4780dec098cfd04bf5eb9da7f3cce4076
-|    +--- org.greenrobot:eventbus:3.3.1
-|    |    \--- org.greenrobot:eventbus-java:3.3.1
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.1
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.6.2 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.6.2 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
-|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.20 -> 1.9.22 (*)
-|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
-|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6 (*)
-|    +--- androidx.security:security-crypto:1.0.0
-|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|    |    \--- com.google.crypto.tink:tink-android:1.5.0
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
-|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-|    +--- org.apache.commons:commons-text:1.10.0
-|    |    \--- org.apache.commons:commons-lang3:3.12.0
-|    +--- androidx.room:room-runtime:2.4.2 -> 2.5.0
-|    |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.1 -> 2.2.0 (*)
-|    |    +--- androidx.room:room-common:2.5.0
-|    |    |    +--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 -> 1.9.10 (*)
-|    |    +--- androidx.sqlite:sqlite:2.3.0
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
-|    |    \--- androidx.sqlite:sqlite-framework:2.3.0
-|    |         +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|    |         +--- androidx.sqlite:sqlite:2.3.0 (*)
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
-|    +--- androidx.room:room-ktx:2.4.2 -> 2.5.0
-|    |    +--- androidx.room:room-common:2.5.0 (*)
-|    |    +--- androidx.room:room-runtime:2.5.0 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.7.3 (*)
-|    +--- com.google.dagger:dagger:2.42 -> 2.50
-|    |    \--- javax.inject:javax.inject:1
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.7.3 (*)
++--- org.wordpress:fluxc:{strictly trunk-c670e916346bdaa2379936dd8dbb6750766ca319} -> trunk-c670e916346bdaa2379936dd8dbb6750766ca319 FAILED
 +--- org.wordpress:utils:{strictly 3.14.0} -> 3.14.0
-|    +--- org.apache.commons:commons-text:1.10.0 (*)
+|    +--- org.apache.commons:commons-text:1.10.0
+|    |    \--- org.apache.commons:commons-lang3:3.12.0
-|    \--- org.greenrobot:eventbus:3.3.1 (*)
+|    \--- org.greenrobot:eventbus:3.3.1
+|         \--- org.greenrobot:eventbus-java:3.3.1
 +--- org.wordpress:login:1.16.0
-|    +--- org.wordpress:fluxc:trunk-ed60798b4d96ec19863c74b0f525e2e20f4525db -> 3045-5fc175e4780dec098cfd04bf5eb9da7f3cce4076 (*)
+|    +--- org.wordpress:fluxc:trunk-ed60798b4d96ec19863c74b0f525e2e20f4525db -> trunk-c670e916346bdaa2379936dd8dbb6750766ca319 FAILED
-|    \--- com.google.dagger:dagger:2.47 -> 2.50 (*)
+|    \--- com.google.dagger:dagger:2.47 -> 2.50
+|         \--- javax.inject:javax.inject:1
 \--- androidx.work:work-runtime:2.9.0
-     \--- androidx.room:room-ktx:2.5.0 (*)
+     \--- androidx.room:room-ktx:2.5.0
+          +--- androidx.room:room-common:2.5.0
+          |    +--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 -> 1.9.10 (*)
+          +--- androidx.room:room-runtime:2.5.0
+          |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
+          |    +--- androidx.arch.core:core-runtime:2.0.1 -> 2.2.0 (*)
+          |    +--- androidx.room:room-common:2.5.0 (*)
+          |    +--- androidx.sqlite:sqlite:2.3.0
+          |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+          |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
+          |    \--- androidx.sqlite:sqlite-framework:2.3.0
+          |         +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+          |         +--- androidx.sqlite:sqlite:2.3.0 (*)
+          |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
+          +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
+          \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.7.3 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21048-1be33c4
Commit1be33c4
Direct Downloadjetpack-prototype-build-pr21048-1be33c4.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21048-1be33c4
Commit1be33c4
Direct Downloadwordpress-prototype-build-pr21048-1be33c4.apk
Note: Google Login is not supported on these builds.

@dcalhoun dcalhoun marked this pull request as ready for review July 10, 2024 16:33
@dcalhoun dcalhoun requested a review from jkmassel July 10, 2024 16:33
@dcalhoun dcalhoun merged commit 06b5045 into trunk Jul 10, 2024
20 checks passed
@dcalhoun dcalhoun deleted the build/update-fluxc-refence-to-trunk branch July 10, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants