Catch ZipException when inflating #21060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21060-8d89a13 | |
| Commit | 8d89a13 | |
| Direct Download | jetpack-prototype-build-pr21060-8d89a13.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21060-8d89a13 | |
| Commit | 8d89a13 | |
| Direct Download | wordpress-prototype-build-pr21060-8d89a13.apk |
This was referenced Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21040
One change in Android 14 is that a
ZipExceptionmay be thrown during ZIP inflation due to the ZIP traversal exploit.Scanning our code base I found only a single instance of ZIP inflation, so this small PR addresses this one situation. Note that since the ZIP is opened via
setInputwith aByteArrayas opposed to from a file, this exploit may not even be a possibility. However, I felt the exception handling should still be added for safety.