Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental per app feature flag #21521

Merged

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Dec 12, 2024

This PR removes the experimental feature flag for per app language prefs, which enables per app prefs for all users. This targets the feature/per-app-language-prefs feature branch rather than trunk because there's much more work to do before this feature can be released (most notably, dropping the LocaleAwareActivity). In addition, we also want the experimental feature flag to be available in at least one release before removing it.

Test 1:

  • Run the app on a device using Android 13 or later
  • Go to App Settings and tap "Interface language"
  • Note that the system dialog for "App Language" appears instead of our own
  • Verify changing languages works

Test 2:

  • Perform the above with an older device and verify our own language dialog appears and changing languages works

@dangermattic
Copy link
Collaborator

dangermattic commented Dec 12, 2024

1 Warning
⚠️ strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.

Generated by 🚫 Danger

@nbradbury nbradbury marked this pull request as ready for review December 12, 2024 15:55
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 12, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21521-c62e604
Commitc62e604
Direct Downloadwordpress-prototype-build-pr21521-c62e604.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 12, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21521-c62e604
Commitc62e604
Direct Downloadjetpack-prototype-build-pr21521-c62e604.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.44%. Comparing base (f537145) to head (c62e604).
Report is 11 commits behind head on feature/per-app-language-prefs.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           feature/per-app-language-prefs   #21521   +/-   ##
===============================================================
  Coverage                           39.44%   39.44%           
===============================================================
  Files                                2119     2119           
  Lines                               99556    99556           
  Branches                            15313    15313           
===============================================================
  Hits                                39269    39269           
  Misses                              56806    56806           
  Partials                             3481     3481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @nbradbury !

I have reviewed and tested this PR as per the instructions, everything works as expected, great clean-up! 🧹 🧹 🧹


I have left few questions (❓)and some minor (🔍) comments for you to consider. I am going to approve this PR anyway, since none is blocking and I don't want to block progress on this. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.

Copy link

sonarcloud bot commented Dec 13, 2024

@nbradbury nbradbury merged commit 81c2235 into feature/per-app-language-prefs Dec 13, 2024
22 checks passed
@nbradbury nbradbury deleted the issue/remove-per-app-feature-flag branch December 13, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants