Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Update target sdk from 33 to 34. #2946

Merged
merged 2 commits into from
Jan 26, 2024
Merged

[Fix] Update target sdk from 33 to 34. #2946

merged 2 commits into from
Jan 26, 2024

Conversation

notandyvee
Copy link
Contributor

Related: #2942

Update targetSdk version from 33 to 34.

  • Checkout this branch
  • Use this branch through WP (uncomment locaFluxCPath in local-builds.gradle)
  • Log out if already logged in
  • Try out login and various flows
  • Ensure, no issues or crashes

@notandyvee notandyvee added the Android 14 Updates to comply with Android 14 changes. label Jan 23, 2024
@notandyvee notandyvee requested a review from irfano January 23, 2024 22:31
@irfano
Copy link
Member

irfano commented Jan 24, 2024

I conducted smoke tests on WordPress-Android, and it works properly. 🟢
The same issue with the Robolectric version (wordpress-mobile/AztecEditor-Android#1074 (comment)) also affects here.
I will approve and merge once it is resolved.

irfano
irfano approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the unit tests are working. Thanks for the fix. LGTM! 👍🏻

@irfano irfano merged commit 1bb762c into trunk Jan 26, 2024
13 checks passed
@irfano irfano deleted the fix/target-sdk-34-update branch January 26, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfano irfano irfano approved these changes

Assignees
No one assigned
Labels
Android 14 Updates to comply with Android 14 changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notandyvee @irfano