Update Video block test case #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
reviewed
Feb 21, 2024
Comment on lines
+22
to
+23
| - Expect the block's placeholder to show the paused progress bar | ||
| <img src="../../test-cases/resources/../resources/video-upload-progress.jpg" width="260"> |
There was a problem hiding this comment.
I believe this is incorrect.
This describes WordPress/gutenberg#59247, but that only applies to Media & Text and should not occur (i.e., a known regression). Do you experience WordPress/gutenberg#59247 for Video blocks as well? I do not on iOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the precondition of both Video and Media & Text blocks.
It also updates some screenshots and steps for the Video block.