Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timing adjustments to checkExec #44

Merged
merged 1 commit into from
May 11, 2015

Conversation

jkbits1
Copy link
Contributor

@jkbits1 jkbits1 commented Sep 6, 2014

These changes enable my Linux set-up (details below) to pass the final offloading tutorial step. They are in this PR to create a discussion on whether they are necessary, or are due to other issues.

Edit: This may be the same problem reported in #38.

Without these changes, the actual sleep time exceeds the upper bound on both checks. For the first check, the sleep time is approx 370ms, and for the second, approx 1400ms. From memory and a quick google search, the time provided to Windows Sleep() is considered a guide only, and a wake time of 111ms is a bit on the low side. I have no personal coding experience of usleep() to comment on.

My set-up: Oracle VirtualBox VM running Ubuntu 12.04 LTS (32-bit) on a Windows host machine.

Testing: the changes have been tested as follows:

After creating a fork of goingnative, I copied my solution folder "myaddon" to the goingnative folder, and made the edits to the relevant exercise.js (in the "exercises\offloading*" folder). The code was tested several times in debug and normal mode.

The code was debugged with node-inspector:
node-debug goingnative.js verify myaddon

The code was also run with the same command line, but just with node.

rvagg added a commit that referenced this pull request May 11, 2015
@rvagg rvagg merged commit 3e94007 into workshopper:master May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants