retry tests with sleep once after node-gyp rebuild #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a usually failing check for exercise "CALL ME MAYBE" might also possibly fix issue workshopper#93 Signed-off-by: Harald Fassler <harald.fassler+9974@gmail.com>
|
Thank you for providing inspiration for fixing this bug. I took the liberty to rewrite it a bit in 81fc044 (reuse and stuff) Published with 2.1.0 |
|
Happy you liked my input! to be honest I saw that some reuse would be appropriate, but I was just not bold enough to propose it. 😁 Glad that's done now too! thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a usually failing check for exercise "CALL ME MAYBE"
might also possibly fix issue #93
The check of the exercise "CALL ME MAYBE" usually fails for me:
I observed that runtime is usually higher after a fresh
node-gyp rebuild. Therefor I suggest fot the two tests "CALL ME MAYBE" and "OFFLOADING THE WORK" to retry the runtime duration check once, if it fails in the first place.(GutHub marks a lot of lines changed, but these are mostly whitespace changes).