Migrate commands/events into payload to enable more generic message passing #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oad section and utilize destination header in root of RelayMessage
TheButlah
approved these changes
Aug 12, 2024
| } | ||
| } | ||
|
|
||
| message RelayMessage { |
There was a problem hiding this comment.
would it make sense to have an optional origin string too?
There was a problem hiding this comment.
Definitely could make sense. I'll hold off on adding until we see a viable use case for it. Easy to add :)
There was a problem hiding this comment.
Actually... Don't we need it even now? Imagine self serve flow scenario. App sends message to Orb. Orb needs to know where to respond.
Our self serve integration tests rely on having both clients know each other app_id and orb_id - that's just how we wrote tests.
In real life scenario, app or orb that receive message, will not know the sender - we should add it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies existing message format to migrate commands/events into a payload section and utilize destination header in root of RelayMessage. This allows us to be more generic with respect to our software architecture, and pass relay messages around which can be inspected for payload. We can also utilize the default destination field present in all orb-relay messages to enable new application behaviors that do not require dedicated handlers in the service.