simulate before broadcasting

worldcoin · May 2, 2024 · c1e660e · c1e660e
1 parent 43142e8
commit c1e660e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/src/contracts/mod.rs b/src/contracts/mod.rs
@@ -260,10 +260,6 @@ impl IdentityManager {
             )
             .tx;
 
-        self.ethereum
-            .simulate_transaction(&register_identities_transaction)
-            .await?;
-
         self.ethereum
             .send_transaction(register_identities_transaction, true)
             .await
@@ -291,10 +287,6 @@ impl IdentityManager {
             )
             .tx;
 
-        self.ethereum
-            .simulate_transaction(&delete_identities_transaction)
-            .await?;
-
         self.ethereum
             .send_transaction(delete_identities_transaction, true)
             .await

diff --git a/src/ethereum/mod.rs b/src/ethereum/mod.rs
@@ -72,16 +72,12 @@ impl Ethereum {
         tx: TypedTransaction,
         only_once: bool,
     ) -> Result<TransactionId, TxError> {
-        self.write_provider.send_transaction(tx, only_once).await
-    }
-
-    pub async fn simulate_transaction(&self, tx: &TypedTransaction) -> Result<(), TxError> {
         if let Err(err) = self.read_provider.call(&tx, None).await {
             tracing::error!("Error simulating transaction: {:?}", err);
             return Err(TxError::Simulate(anyhow::Error::new(err)));
         }
 
-        Ok(())
+        self.write_provider.send_transaction(tx, only_once).await
     }
 
     pub async fn fetch_pending_transactions(&self) -> Result<Vec<TransactionId>, TxError> {