Fix restoring tree when there are no commitments added. #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piohei
force-pushed
the
fix_tree_restore
branch
from
bb1ac3b to
f6d36a0
Compare
Dzejkop
reviewed
Apr 26, 2024
Dzejkop
reviewed
Apr 26, 2024
Dzejkop
reviewed
Apr 26, 2024
Dzejkop
approved these changes
Apr 26, 2024
piohei
force-pushed
the
fix_tree_restore
branch
from
f6d36a0 to
9f937b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When empty tree was being restored from file starting index was 1 instead of 0. It shouldn't be a big deal for production but may be problematic in some test cases. And still it is a bug - so nice to be fixed.
Solution
When tree is being restored instead of using zero as default value None optional is used to indicate that actually there is no latest index as there are no used indexes at all.
PR Checklist