Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre_root for identities. #781

Merged
merged 2 commits into from
Oct 14, 2024

Fix down migration.

7ec6199
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Add pre_root for identities. #781

Fix down migration.
7ec6199
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Oct 14, 2024 in 0s

clippy

19 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 19
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 221 in src/bin/tool.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/bin/tool.rs:221:23
    |
221 |                 .post(&format!("{}/inclusionProof", args.sequencer_url))
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/inclusionProof", args.sequencer_url)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 202 in src/bin/tool.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/bin/tool.rs:202:23
    |
202 |                 .post(&format!("{}/verifySemaphoreProof", args.sequencer_url))
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/verifySemaphoreProof", args.sequencer_url)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 170 in src/bin/tool.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/bin/tool.rs:170:23
    |
170 |                 .post(&format!("{}/inclusionProof", args.sequencer_url))
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/inclusionProof", args.sequencer_url)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 144 in src/bin/tool.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/bin/tool.rs:144:23
    |
144 |                 .post(&format!("{}/insertIdentity", args.sequencer_url))
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/insertIdentity", args.sequencer_url)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 221 in src/bin/tool.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/bin/tool.rs:221:23
    |
221 |                 .post(&format!("{}/inclusionProof", args.sequencer_url))
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/inclusionProof", args.sequencer_url)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 202 in src/bin/tool.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/bin/tool.rs:202:23
    |
202 |                 .post(&format!("{}/verifySemaphoreProof", args.sequencer_url))
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/verifySemaphoreProof", args.sequencer_url)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 170 in src/bin/tool.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/bin/tool.rs:170:23
    |
170 |                 .post(&format!("{}/inclusionProof", args.sequencer_url))
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/inclusionProof", args.sequencer_url)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 144 in src/bin/tool.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/bin/tool.rs:144:23
    |
144 |                 .post(&format!("{}/insertIdentity", args.sequencer_url))
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/insertIdentity", args.sequencer_url)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 21 in src/ethereum/read/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `legacy` is never read

warning: field `legacy` is never read
  --> src/ethereum/read/mod.rs:21:9
   |
18 | pub struct ReadProvider {
   |            ------------ field in this struct
...
21 |     pub legacy:   bool,
   |         ^^^^^^
   |
   = note: `ReadProvider` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

Check warning on line 89 in src/database/types.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `batch_next_root` and `transaction_id` are never read

warning: fields `batch_next_root` and `transaction_id` are never read
  --> src/database/types.rs:89:9
   |
88 | pub struct TransactionEntry {
   |            ---------------- fields in this struct
89 |     pub batch_next_root: Hash,
   |         ^^^^^^^^^^^^^^^
90 |     pub transaction_id:  String,
   |         ^^^^^^^^^^^^^^
   |
   = note: `TransactionEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 189 in src/database/query.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods `get_latest_root`, `get_latest_batch_with_transaction`, `get_all_batches_after`, `root_in_batch_chain`, and `get_transaction_for_batch` are never used

warning: methods `get_latest_root`, `get_latest_batch_with_transaction`, `get_all_batches_after`, `root_in_batch_chain`, and `get_transaction_for_batch` are never used
   --> src/database/query.rs:189:14
    |
24  | pub trait DatabaseQuery<'a>: Executor<'a, Database = Postgres> {
    |           ------------- methods in this trait
...
189 |     async fn get_latest_root(self) -> Result<Option<Hash>, Error> {
    |              ^^^^^^^^^^^^^^^
...
704 |     async fn get_latest_batch_with_transaction(self) -> Result<Option<BatchEntry>, Error> {
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
770 |     async fn get_all_batches_after(self, id: i64) -> Result<Vec<BatchEntry>, Error> {
    |              ^^^^^^^^^^^^^^^^^^^^^
...
816 |     async fn root_in_batch_chain(self, root: &Hash) -> Result<bool, Error> {
    |              ^^^^^^^^^^^^^^^^^^^
...
846 |     async fn get_transaction_for_batch(
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 21 in src/ethereum/read/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `legacy` is never read

warning: field `legacy` is never read
  --> src/ethereum/read/mod.rs:21:9
   |
18 | pub struct ReadProvider {
   |            ------------ field in this struct
...
21 |     pub legacy:   bool,
   |         ^^^^^^
   |
   = note: `ReadProvider` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

Check warning on line 89 in src/database/types.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `batch_next_root` and `transaction_id` are never read

warning: fields `batch_next_root` and `transaction_id` are never read
  --> src/database/types.rs:89:9
   |
88 | pub struct TransactionEntry {
   |            ---------------- fields in this struct
89 |     pub batch_next_root: Hash,
   |         ^^^^^^^^^^^^^^^
90 |     pub transaction_id:  String,
   |         ^^^^^^^^^^^^^^
   |
   = note: `TransactionEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 23 in src/database/types.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `existing_commitment` is never read

warning: field `existing_commitment` is never read
  --> src/database/types.rs:23:9
   |
22 | pub struct RecoveryEntry {
   |            ------------- field in this struct
23 |     pub existing_commitment: Hash,
   |         ^^^^^^^^^^^^^^^^^^^

Check warning on line 189 in src/database/query.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

multiple methods are never used

warning: multiple methods are never used
   --> src/database/query.rs:189:14
    |
24  | pub trait DatabaseQuery<'a>: Executor<'a, Database = Postgres> {
    |           ------------- methods in this trait
...
189 |     async fn get_latest_root(self) -> Result<Option<Hash>, Error> {
    |              ^^^^^^^^^^^^^^^
...
442 |     async fn get_all_recoveries(self) -> Result<Vec<RecoveryEntry>, Error> {
    |              ^^^^^^^^^^^^^^^^^^
...
662 |     async fn get_next_batch(self, prev_root: &Hash) -> Result<Option<BatchEntry>, Error> {
    |              ^^^^^^^^^^^^^^
...
704 |     async fn get_latest_batch_with_transaction(self) -> Result<Option<BatchEntry>, Error> {
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
770 |     async fn get_all_batches_after(self, id: i64) -> Result<Vec<BatchEntry>, Error> {
    |              ^^^^^^^^^^^^^^^^^^^^^
...
816 |     async fn root_in_batch_chain(self, root: &Hash) -> Result<bool, Error> {
    |              ^^^^^^^^^^^^^^^^^^^
...
846 |     async fn get_transaction_for_batch(
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 21 in src/ethereum/read/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `legacy` is never read

warning: field `legacy` is never read
  --> src/ethereum/read/mod.rs:21:9
   |
18 | pub struct ReadProvider {
   |            ------------ field in this struct
...
21 |     pub legacy:   bool,
   |         ^^^^^^
   |
   = note: `ReadProvider` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

Check warning on line 89 in src/database/types.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `batch_next_root` and `transaction_id` are never read

warning: fields `batch_next_root` and `transaction_id` are never read
  --> src/database/types.rs:89:9
   |
88 | pub struct TransactionEntry {
   |            ---------------- fields in this struct
89 |     pub batch_next_root: Hash,
   |         ^^^^^^^^^^^^^^^
90 |     pub transaction_id:  String,
   |         ^^^^^^^^^^^^^^
   |
   = note: `TransactionEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 23 in src/database/types.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `existing_commitment` is never read

warning: field `existing_commitment` is never read
  --> src/database/types.rs:23:9
   |
22 | pub struct RecoveryEntry {
   |            ------------- field in this struct
23 |     pub existing_commitment: Hash,
   |         ^^^^^^^^^^^^^^^^^^^

Check warning on line 189 in src/database/query.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

multiple methods are never used

warning: multiple methods are never used
   --> src/database/query.rs:189:14
    |
24  | pub trait DatabaseQuery<'a>: Executor<'a, Database = Postgres> {
    |           ------------- methods in this trait
...
189 |     async fn get_latest_root(self) -> Result<Option<Hash>, Error> {
    |              ^^^^^^^^^^^^^^^
...
442 |     async fn get_all_recoveries(self) -> Result<Vec<RecoveryEntry>, Error> {
    |              ^^^^^^^^^^^^^^^^^^
...
662 |     async fn get_next_batch(self, prev_root: &Hash) -> Result<Option<BatchEntry>, Error> {
    |              ^^^^^^^^^^^^^^
...
704 |     async fn get_latest_batch_with_transaction(self) -> Result<Option<BatchEntry>, Error> {
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
770 |     async fn get_all_batches_after(self, id: i64) -> Result<Vec<BatchEntry>, Error> {
    |              ^^^^^^^^^^^^^^^^^^^^^
...
816 |     async fn root_in_batch_chain(self, root: &Hash) -> Result<bool, Error> {
    |              ^^^^^^^^^^^^^^^^^^^
...
846 |     async fn get_transaction_for_batch(
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default