Relax transaction isolation levels + fix insert identities constraints #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dzejkop
commented
Oct 18, 2024
| /// Will return `Err` if identity is already queued for deletion, not in the | ||
| /// tree, or the queue malfunctions. | ||
| #[instrument(level = "debug", skip(self))] | ||
| pub async fn recover_identity( |
There was a problem hiding this comment.
First step in disabling recovery - deleting the API endpoint
Dzejkop
commented
Oct 18, 2024
| ); | ||
| tx.insert_pending_identity(leaf_idx, identity, &root, &pre_root) | ||
| .await | ||
| .expect("Failed to insert identity - tree will be out of sync"); |
There was a problem hiding this comment.
The most critical change in this PR is this and the other expect on line 70.
These are necessary to keep the sequencer state in sync with the db
There was a problem hiding this comment.
I guess my only question is will the identity be completely lost here if this fails? And therein all unprocessed identities prior? Same below with tx.commit() failing. Just wondering what the flow would be after restart
Dzejkop
commented
Oct 18, 2024
| @@ -213,76 +209,11 @@ impl App { | |||
| return Err(ServerError::IdentityAlreadyDeleted); | |||
| } | |||
|
|
|||
| // Check if the id is already queued for deletion | |||
| if tx.identity_is_queued_for_deletion(commitment).await? { | |||
There was a problem hiding this comment.
the insert_new_deletion method has been changed to be idempotent. Therefore there's no longer a need to check if we have already accepted a deletion
0xKitsune
approved these changes
Oct 18, 2024
Dzejkop
force-pushed
the
dzejkop/resolve-tx-issues
branch
from
aaaa9d9 to
3f9b79b
Compare
0xKitsune
approved these changes
Oct 21, 2024
0xOsiris
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.