Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove recovery related code #797

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Remove recovery related code #797

merged 5 commits into from
Oct 22, 2024

Conversation

Dzejkop
Copy link
Contributor

@Dzejkop Dzejkop commented Oct 21, 2024

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation

@Dzejkop Dzejkop force-pushed the dzejkop/remove-recovery branch from 428daf1 to c5cab66 Compare October 21, 2024 18:19
@Dzejkop Dzejkop marked this pull request as ready for review October 22, 2024 11:58
@Dzejkop Dzejkop requested a review from a team as a code owner October 22, 2024 11:58
@Dzejkop Dzejkop changed the title WIP: Remove recovery Remove recovery related code Oct 22, 2024
0xOsiris
0xOsiris approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@0xOsiris 0xOsiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, only concern is this endpoint is stilled hooked into production in app/maybe other places. Have we notified teams this endpoint will not exist anymore?

0xForerunner
0xForerunner approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@0xForerunner 0xForerunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of removed code. Feels good.

@Dzejkop
Copy link
Contributor Author

Dzejkop commented Oct 22, 2024 •
edited
Loading

This LGTM, only concern is this endpoint is stilled hooked into production in app/maybe other places. Have we notified teams this endpoint will not exist anymore?

yep, and we've not been receiving any traffic to this endpoint in over a month

@Dzejkop Dzejkop merged commit 1d18ba4 into main Oct 22, 2024
5 checks passed
@Dzejkop Dzejkop deleted the dzejkop/remove-recovery branch October 22, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xOsiris 0xOsiris 0xOsiris approved these changes

@0xForerunner 0xForerunner 0xForerunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dzejkop @0xForerunner @0xOsiris