Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shutdown. #822

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix shutdown. #822

merged 1 commit into from
Nov 27, 2024

Conversation

piohei
Copy link
Contributor

@piohei piohei commented Nov 12, 2024

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation

@piohei piohei requested a review from a team as a code owner November 12, 2024 15:36
0xForerunner
0xForerunner approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@0xForerunner 0xForerunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I'm assuming this was to fix the integration tests?

@0xForerunner 0xForerunner merged commit 2c57948 into main Nov 27, 2024
5 checks passed
@0xForerunner 0xForerunner deleted the piohei/fix_shutdown branch November 27, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xOsiris 0xOsiris 0xOsiris approved these changes

@0xForerunner 0xForerunner 0xForerunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piohei @0xForerunner @0xOsiris