Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-identity & idComm generation #15

Merged
merged 2 commits into from
Nov 28, 2024
Merged

multi-identity & idComm generation #15

merged 2 commits into from
Nov 28, 2024

Conversation

pdtfh
Copy link
Contributor

@pdtfh pdtfh commented Nov 27, 2024

  • Enables support so that Identity can actually be used for all supported credentials instead of a single one. This requires keeping the secret_hex in memory. See code comments for security details (to be further discussed with the security team).
  • Introduces CredentialType to represent the different credentials that can be used with a single World ID.
  • Enables identity commitment generation for specific credentials.

@pdtfh pdtfh requested a review from sevazhidkov November 27, 2024 23:48
Copy link

@sevazhidkov sevazhidkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but checking Identity::from_secret arguments in Slack

@pdtfh pdtfh merged commit 03583cd into main Nov 28, 2024
5 checks passed
@pdtfh pdtfh deleted the identity-base branch November 28, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants