Merge pull request #46 from worldcoin/osiris/better-tx-validation

Osiris/better tx validation

world-chain-builder/src/pool/validator.rs

@@ -131,16 +131,16 @@ where
         transaction: &Tx,
         payload: &PbhPayload,
     ) -> Result<(), TransactionValidationError> {
+        self.validate_root(payload)?;
+        let date = chrono::Utc::now();
+        self.validate_external_nullifier(date, payload)?;
+
         // Create db transaction and insert the nullifier hash
         // We do this first to prevent repeatedly validating the same transaction
         let db_tx = self.pbh_db.tx_mut()?;
         let mut cursor = db_tx.cursor_write::<ValidatedPbhTransactionTable>()?;
         cursor.insert(payload.nullifier_hash.to_be_bytes().into(), EmptyValue)?;
 
-        let date = chrono::Utc::now();
-        self.validate_root(payload)?;
-        self.validate_external_nullifier(date, payload)?;
-
         let res = verify_proof(
             payload.root,
             payload.nullifier_hash,