Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tilt #197

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Enable tilt #197

merged 2 commits into from
Mar 1, 2024

Conversation

evan-gray
Copy link
Contributor

No description provided.

@evan-gray evan-gray changed the base branch from main to eg/e2e February 25, 2024 18:11
Base automatically changed from eg/e2e to main February 25, 2024 23:45
@evan-gray evan-gray marked this pull request as ready for review February 28, 2024 17:04
Copy link
Collaborator

@djb15 djb15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glossed over the bindings but I'm on-board with enabling tilt tests

.github/workflows/tilt.yml Show resolved Hide resolved
@johnsaigle
Copy link
Collaborator

johnsaigle commented Feb 29, 2024

Looks good to me! I'm not sure that I'm a privileged member of the repo though so you'll still need someone else to weigh in, I think? 😄

My only note is that GitHub is flagging the branch as out-of-date. Might be worth a rebase-and-push in case GitHub doesn't allow you to merge because of this?

@evan-gray evan-gray force-pushed the enable-tilt branch 2 times, most recently from da4a226 to 0562b23 Compare February 29, 2024 19:46
@evan-gray
Copy link
Contributor Author

will follow up with another regen in #229 which also contains some test fixes

@evan-gray evan-gray merged commit f0f087c into main Mar 1, 2024
3 of 5 checks passed
@evan-gray evan-gray deleted the enable-tilt branch March 1, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants