Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add useful event info #199

Merged
merged 1 commit into from
Feb 26, 2024
Merged

add useful event info #199

merged 1 commit into from
Feb 26, 2024

Conversation

RahulMaganti47
Copy link
Contributor

Fixes #184 + more

@kev1n-peters
Copy link
Contributor

kev1n-peters commented Feb 26, 2024 •
edited
Loading

Would it be possible to change event TransferRedeemed(bytes32 digest) to event TransferRedeemed(bytes32 indexed digest)? This way the redeem event for a digest can be queried efficiently. I realize it's not changed in this PR, but maybe we could stick it in?

@RahulMaganti47 RahulMaganti47 merged commit c4a3737 into main Feb 26, 2024
3 of 4 checks passed
@RahulMaganti47 RahulMaganti47 deleted the add-event-info branch February 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gator-boi gator-boi gator-boi approved these changes

@kcsongor kcsongor Awaiting requested review from kcsongor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add msg.value to event
3 participants
@RahulMaganti47 @kev1n-peters @gator-boi