solana: Add build, test, and lint Makefile targets to top-level dir #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
changed the title
johnsaigle
force-pushed
the
solana/tests-in-make
branch
2 times, most recently
from
bf279a9
to
31a4153
Compare
johnsaigle
force-pushed
the
solana/tests-in-make
branch
from
31a4153
to
2974b80
Compare
johnsaigle
force-pushed
the
solana/tests-in-make
branch
from
2974b80
to
c63e57e
Compare
nvsriram
force-pushed
the
solana/tests-in-make
branch
from
c63e57e
to
f41e2b5
Compare
Adds Makefile targets for common Solana tasks in the top-level directory. This allows the test and build pipeline to be run from the main directory for both the EVM and Solana implementations. This also helps to capture the Solana commands that are configured in the .github/workflows/solana.yml file. In case this codebase is merged or adapted into the Wormhole monorepo, the GitHub workflow may be removed for modified. Therefore it is beneficial to track the expected test configurations here.
nvsriram
force-pushed
the
solana/tests-in-make
branch
from
f41e2b5
to
c3fb41b
Compare
|
Changes merged through #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Makefile targets for common Solana tasks in the top-level directory. This allows the test and build pipeline to be run from the main directory for both the EVM and Solana implementations.
This also helps to capture the Solana commands that are configured in the .github/workflows/solana.yml file. In case this codebase is merged or adapted into the Wormhole monorepo, the GitHub workflow may be removed for modified. Therefore it is beneficial to track the expected test configurations here.
See also: #285. Part of the motivation for adding these Makefile targets is to configure additional clippy rules that can be run locally in addition to CI runs.