EVM: NttManagerWithoutRateLimiting #519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
evm_NttManagerWithoutRateLimiting
branch
4 times, most recently
from
439bcbe
to
f7e35bc
Compare
bruce-riley
force-pushed
the
evm_NttManagerWithoutRateLimiting
branch
from
f7e35bc
to
4f09f85
Compare
bruce-riley
force-pushed
the
evm_NttManagerWithoutRateLimiting
branch
2 times, most recently
from
a05d871
to
cc45269
Compare
bruce-riley
force-pushed
the
evm_NttManagerWithoutRateLimiting
branch
from
cc45269
to
2da6b15
Compare
|
I verified that the output from these commands match the output from the NttManager contract on main. This should ensure that the external interfaces have not changed. |
|
Closing this in favor of #520 which supports a smaller diff and an easier migration strategy (for those who disabled rate limiting) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks up the EVM NTT Manager into two components, the existing
NttManager, which works as always and a newNttManagerWithoutRateLimiting, which does not do rate limiting. This allows integrators to chose whether or not they wish to use rate limiting.This is done by adding an abstract contract called
NttManagerBasewhich contains most of the implementation, except for rate limiting.The
NttManagerWithoutRateLimitingdoes not implement rate limiting, but it does implement thatIRateLimiterinterface. This is being done to maintain ABI compatibility between the two contracts.This change increases the size of the
NttManager contractby 67 bytes (leaving 90 bytes free).The
NttManagerWithoutRateLimitingcontract has 6689 bytes free.