evm: pass consistencyLevel to WormholeRelayer during send #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xIryna
changed the title
evan-gray
approved these changes
Nov 1, 2024
nik-suri
approved these changes
Nov 7, 2024
nik-suri
force-pushed
the
fix/pass-consistency-level-to-relayer
branch
from
803267b
to
802d7e5
Compare
evan-gray
force-pushed
the
fix/pass-consistency-level-to-relayer
branch
from
802d7e5
to
c4cfae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
WormholeTransceivertakesconsistencyLevelin the constructor, but doesn't pass it toWormholeRelayerin_sendMessageresulting inFINALIZEDconsistency level being used by default.Proposed Changes
IWormholeRelayer.sendPayloadToEvmfunction call was replaced withIWormholeRelayer.sendToEvmto allow passing consistency level. The rest of parameters were filled fromWormholeRelayerimplementation.Tests
I'm happy to add tests for the proposed changes, but there isn't any existing tests for the Transceivers