Removing unnecessary SDK calls during initial load (#2137)

Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
wormhole-foundation · May 28, 2024 · 50413f9 · 50413f9
1 parent e422da6
commit 50413f9
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/wormhole-connect/src/routes/sdkv2/route.ts b/wormhole-connect/src/routes/sdkv2/route.ts
@@ -101,10 +101,10 @@ export class SDKv2Route<N extends Network> extends RouteAbstract {
 
     return routes.RouteTransferRequest.create(
       wh,
+      /* @ts-ignore */
       {
         source: srcTokenV2,
         destination: dstTokenV2,
-        /* @ts-ignore */
       },
       srcChain,
       dstChain,

diff --git a/wormhole-connect/src/views/Bridge/Bridge.tsx b/wormhole-connect/src/views/Bridge/Bridge.tsx
@@ -115,8 +115,12 @@ function Bridge() {
 
   // check destination native balance
   useEffect(() => {
-    if (!fromChain || !toChain || !receiving.address) return;
+    if (!fromChain || !toChain || !receiving.address) {
+      return;
+    }
+
     const chainConfig = config.chains[toChain]!;
+
     config.wh
       .getNativeBalance(receiving.address, toChain)
       .then((res: BigNumber) => {
@@ -132,7 +136,12 @@ function Bridge() {
   }, [fromChain, toChain, receiving.address, dispatch]);
 
   useEffect(() => {
+    if (!fromChain) {
+      return;
+    }
+
     let active = true;
+
     const computeSrcTokens = async () => {
       const supported = await RouteOperator.allSupportedSourceTokens(
         config.tokens[destToken],
@@ -150,14 +159,20 @@ function Bridge() {
         }
       }
     };
+
     computeSrcTokens();
+
     return () => {
       active = false;
     };
     // IMPORTANT: do not include token in dependency array
   }, [route, fromChain, destToken, dispatch]);
 
   useEffect(() => {
+    if (!toChain) {
+      return;
+    }
+
     let canceled = false;
 
     const computeDestTokens = async () => {
@@ -231,21 +246,28 @@ function Bridge() {
         }
       }
     };
+
     computeDestTokens();
+
     return () => {
       canceled = true;
     };
     // IMPORTANT: do not include destToken in dependency array
   }, [route, token, fromChain, toChain, dispatch]);
 
   useEffect(() => {
+    if (!route || !amount || !token || !destToken || !fromChain || !toChain) {
+      return;
+    }
+
     const recomputeReceive = async () => {
-      if (!route) return;
       try {
         const routeOptions = isPorticoRoute(route)
           ? portico
           : { toNativeToken, relayerFee };
+
         dispatch(setFetchingReceiveAmount());
+
         const newReceiveAmount = await RouteOperator.computeReceiveAmount(
           route,
           Number.parseFloat(amount),