Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-testid hit targets for automated tests #1833

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

artursapek
Copy link
Collaborator

@artursapek artursapek commented Mar 25, 2024

implementing #1679

minor changes I made:

  • the automatic-route-option/manual-route-option label is dynamic with the route's name: route-option-tokenBridge
  • approve-error-message and transaction-error-message are the same component so they are both labeled send-error-message

cc @tsadovska

- chain modal button
- asset menu button
- connect wallet button
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for wormhole-connect-builder ready!

Name Link
🔨 Latest commit 166cb2e
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect-builder/deploys/6601c9a7735cac0008d84121
😎 Deploy Preview https://deploy-preview-1833--wormhole-connect-builder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for wormhole-connect ready!

Name Link
🔨 Latest commit 166cb2e
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect/deploys/6601c9a7a942ea0008da9715
😎 Deploy Preview https://deploy-preview-1833--wormhole-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for wormhole-connect-mainnet ready!

Name Link
🔨 Latest commit 166cb2e
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect-mainnet/deploys/6601c9a7f1245f00080b0803
😎 Deploy Preview https://deploy-preview-1833--wormhole-connect-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@artursapek artursapek marked this pull request as ready for review March 25, 2024 19:13
@artursapek artursapek changed the title WIP: data-testid hit targets for automated tests data-testid hit targets for automated tests Mar 25, 2024
Copy link
Collaborator

@kev1n-peters kev1n-peters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artursapek artursapek merged commit f232766 into development Apr 1, 2024
18 checks passed
@artursapek artursapek deleted the qa-automation-test-id branch April 1, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] [Improvement] Add "data-testid" attributes to simplify elements search in automated tests
2 participants