Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ETH (Ethereum) > Scroll transfers (frankenstein ETH) #2063

Merged
merged 1 commit into from
May 8, 2024

Conversation

kev1n-peters
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented May 8, 2024

Deploy Preview for wormhole-connect ready!

Name Link
🔨 Latest commit acb146e
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect/deploys/663ba281c64dec0008f84184
😎 Deploy Preview https://deploy-preview-2063--wormhole-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 8, 2024

Deploy Preview for wormhole-connect-mainnet ready!

Name Link
🔨 Latest commit acb146e
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect-mainnet/deploys/663ba281bb232c00082d949b
😎 Deploy Preview https://deploy-preview-2063--wormhole-connect-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@artursapek artursapek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we already established this pattern but I think ideally this logic should be implemented in the Route implementation instead, eventually. isRouteSupported should just return false for all these cases.

@kev1n-peters kev1n-peters merged commit 0181c73 into development May 8, 2024
16 checks passed
@kev1n-peters kev1n-peters deleted the scroll-illiquid-fix branch May 8, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants