[Redesign] Fixing which tokens to display whether a wallet is connected #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for wormhole-connect pending review.Visit the deploys page to approve it
|
👷 Deploy request for wormhole-connect-mainnet pending review.Visit the deploys page to approve it
|
emreboga
force-pushed
the
emre/redesign-fix-tokens-list
branch
4 times, most recently
from
6aabcf1
to
df9ce31
Compare
artursapek
previously approved these changes
Sep 24, 2024
|
Categories of tokens that should be included in defaults when wallet is not connected:
Frankenstein tokens and regular Wormhole-wrapped tokens that are not otherwise part of the above (ie. treated as canonical) should not be included. When a wallet is connected, then show whatever the user has a balance of. |
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
emreboga
force-pushed
the
emre/redesign-fix-tokens-list
branch
from
df9ce31
to
e5db696
Compare
emreboga
commented
Sep 24, 2024
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
kev1n-peters
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR displays all tokens supported when no wallet is connected; and the ones with a balance when a wallet is connected. Please see the loom below for details.
Fixes #2674
https://www.loom.com/share/8c78bd459de442b58193e6c2ff93dc03?sid=5cd50d11-a606-4914-99f6-aa92712e3221