Show canonical tokens even when wallet is not connected #2712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wormhole-wrapped Ethereum USDC was not showing with Sui as the source chain, because it's a Wormhole-wrapped token, and we only display those if the user has a balance. However, this token is canonical on Sui, so we want to display it even when the users's wallet isn't connected. Added an `isCanonical` function that the `TokenList` uses. Fixes wormhole-foundation#2690
👷 Deploy request for wormhole-connect pending review.Visit the deploys page to approve it
|
👷 Deploy request for wormhole-connect-mainnet pending review.Visit the deploys page to approve it
|
|
In the ticket, I also noted I'm not able to bridge USDC into Sui at all after wallets are connected (example used was selecting native USDC on Solana for the origin and then seeing no options on Sui for the destination). Does this change also address that? |
This does not, because Wormhole-wrapped Solana USDC is considered a Frankenstein token on Sui |
emreboga
reviewed
Sep 24, 2024
kev1n-peters
merged commit b0dc901
into
wormhole-foundation:development
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wormhole-wrapped Ethereum USDC was not showing with Sui as the source chain, because it's a Wormhole-wrapped token, and we only display those if the user has a balance. However, this token is canonical on Sui, so we want to display it even when the users's wallet isn't connected.
Added an
isCanonicalfunction that theTokenListuses.Fixes #2690