-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Redesign] UI polish for Redeem view #2787
Merged
emreboga
merged 4 commits into
wormhole-foundation:development
from
wormholelabs-xyz:emre/redesign-redeem-view-polish
Oct 7, 2024
Merged
[Redesign] UI polish for Redeem view #2787
emreboga
merged 4 commits into
wormhole-foundation:development
from
wormholelabs-xyz:emre/redesign-redeem-view-polish
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for wormhole-connect pending review.Visit the deploys page to approve it
|
👷 Deploy request for wormhole-connect-mainnet pending review.Visit the deploys page to approve it
|
emreboga
commented
Oct 2, 2024
emreboga
commented
Oct 2, 2024
emreboga
commented
Oct 2, 2024
emreboga
force-pushed
the
emre/redesign-redeem-view-polish
branch
from
October 2, 2024 14:15
b812c9e
to
87087c5
Compare
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
emreboga
force-pushed
the
emre/redesign-redeem-view-polish
branch
from
October 2, 2024 19:41
87087c5
to
f68979b
Compare
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
artursapek
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the UI polish requests which includes a redesign of the Circular Progress bar for both determinate and indeterminate cases (see below). It also cleans up a few more React warnings/errors.
You can see the update for smoother progress bar transition here:
https://www.loom.com/share/67634ad8fceb4d99a82804b39cefb3eb?sid=ba85d219-3077-4940-befc-6a48227d0af9
Screenshots for all UI states: