Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terms standardization #138

Merged
merged 3 commits into from
Nov 13, 2024
Merged

terms standardization #138

merged 3 commits into from
Nov 13, 2024

Conversation

martin0995
Copy link
Collaborator

Description

The NTT Solana Deployment Page needs to be clarified. When following the steps, the page refers to the same thing with a different name, generating confusion.

Example:

  • The newly created token address is referred to as INSERT_YOUR_SPL_TOKEN and INSERT_TOKEN_ADDRESS

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@martin0995 martin0995 added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Nov 11, 2024
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I noticed some other things not related to the changes you made, but I think it makes sense to make these improvements while we're at it. So, if you could please make those changes, that'd be great 🙌

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thanks @martin0995 !

@eshaben eshaben merged commit ab43fad into main Nov 13, 2024
1 check passed
@eshaben eshaben deleted the martinh/ntt-solana-standardization branch November 13, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants