Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ilariae/guardians #4

Merged
merged 19 commits into from
Jul 31, 2024
Merged

Ilariae/guardians #4

merged 19 commits into from
Jul 31, 2024

Conversation

ilariae
Copy link
Collaborator

@ilariae ilariae commented Jul 29, 2024

Description

Guardians page

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@ilariae ilariae added the A0 - New Content Pull request contains new content pages label Jul 29, 2024
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple comments, but please re-read and look for/update the following items:

  • Anywhere "let's", "we", "our", etc. is used and update that to be either "you" or something more generic
  • Remove the dash from multi-sig

Also, I ran one paragraph through grammarly and provided some recs, but can you please run this through and update the rest of the doc as needed?

learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
ilariae and others added 6 commits July 31, 2024 11:36
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I missed a couple things before 😬

learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
learn/infrastructure/guardians.md Outdated Show resolved Hide resolved
Ilaria Enache and others added 4 commits July 31, 2024 18:17
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!! 🚢

@eshaben eshaben merged commit 7b4e82a into main Jul 31, 2024
1 check passed
@eshaben eshaben deleted the ilariae/guardians branch July 31, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants