Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ilariae/spies #5

Merged
merged 25 commits into from
Aug 1, 2024
Merged

Ilariae/spies #5

merged 25 commits into from
Aug 1, 2024

Conversation

ilariae
Copy link
Collaborator

@ilariae ilariae commented Jul 30, 2024

Description

SPY page

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@ilariae ilariae added the A0 - New Content Pull request contains new content pages label Jul 30, 2024
dawnkelly09
dawnkelly09 requested changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small styling changes suggested

learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
ilariae and others added 4 commits July 30, 2024 19:09
@ilariae @dawnkelly09
Update learn/infrastructure/spy.md
c1afba6 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@ilariae @dawnkelly09
Update learn/infrastructure/spy.md
1f95ac8 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
@ilariae @dawnkelly09
Update learn/infrastructure/spy.md
912315d 
Co-authored-by: Dawn Kelly <83190195+dawnkelly09@users.noreply.github.com>
shortened meta description
de6c4bb
eshaben
eshaben reviewed Jul 30, 2024
View reviewed changes
learn/infrastructure/.pages Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
learn/infrastructure/spy.md Outdated Show resolved Hide resolved
ilariae and others added 9 commits July 31, 2024 15:49
@ilariae @eshaben
Update learn/infrastructure/.pages
1832a0a 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
c00a791 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
b0aadce 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
a814dd1 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
2837d49 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
10f1519 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
90c6489 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
655cea3 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
sync with main
858710a
ilariae and others added 6 commits July 31, 2024 21:01
@ilariae @eshaben
Update learn/infrastructure/spy.md
fc05cac 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
ee72ebc 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
a073a2e 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
53186b2 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
6048e06 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@ilariae @eshaben
Update learn/infrastructure/spy.md
d54e796 
Co-authored-by: Erin Shaben <eshaben@icloud.com>
eshaben
eshaben approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@eshaben
Copy link
Collaborator

eshaben commented Aug 1, 2024

@dawnkelly09 all good from your side?

dawnkelly09
dawnkelly09 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@eshaben eshaben merged commit 2ffce02 into main Aug 1, 2024
1 check passed
@eshaben eshaben deleted the ilariae/spies branch August 1, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

@eshaben eshaben eshaben approved these changes

Assignees
No one assigned
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilariae @eshaben @dawnkelly09