Skip to content

Commit

Permalink
add prefix to chacheable and fix deploy (#479)
Browse files Browse the repository at this point in the history
  • Loading branch information
gipsh committed Jun 29, 2023
1 parent 38944ca commit 78bd0cb
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 7 deletions.
2 changes: 1 addition & 1 deletion analytics/cmd/service/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ func newNotionalCache(
redisClient := redis.NewClient(&redis.Options{Addr: cfg.CacheURL})

// get notional cache client and init load to local cache
notionalCache, err := wormscanNotionalCache.NewNotionalCache(ctx, redisClient, cfg.CacheChannel, logger)
notionalCache, err := wormscanNotionalCache.NewNotionalCache(ctx, redisClient, cfg.CachePrefix, cfg.CacheChannel, logger)
if err != nil {
return nil, fmt.Errorf("failed to create notional cache client: %w", err)
}
Expand Down
1 change: 1 addition & 0 deletions analytics/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ type Configuration struct {
PprofEnabled bool `env:"PPROF_ENABLED,default=false"`
P2pNetwork string `env:"P2P_NETWORK,required"`
CacheURL string `env:"CACHE_URL,required"`
CachePrefix string `env:"CACHE_PREFIX,required"`
CacheChannel string `env:"CACHE_CHANNEL,required"`
}

Expand Down
2 changes: 1 addition & 1 deletion api/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ func NewCache(ctx context.Context, cfg *config.AppConfig, logger *zap.Logger) (w
cacheClient, _ := wormscanCache.NewCacheClient(redisClient, cfg.Cache.Enabled, cfg.Cache.Prefix, logger)

// get notional cache client and init load to local cache
notionalCache, _ := wormscanNotionalCache.NewNotionalCache(ctx, redisClient, cfg.Cache.Channel, logger)
notionalCache, _ := wormscanNotionalCache.NewNotionalCache(ctx, redisClient, cfg.Cache.Prefix, cfg.Cache.Channel, logger)
notionalCache.Init(ctx)

return cacheClient, notionalCache
Expand Down
4 changes: 2 additions & 2 deletions common/client/cache/notional/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ type NotionalCache struct {

// NewNotionalCache create a new cache client.
// After create a NotionalCache use the Init method to initialize pubsub and load the cache.
func NewNotionalCache(ctx context.Context, redisClient *redis.Client, channel string, log *zap.Logger) (*NotionalCache, error) {
func NewNotionalCache(ctx context.Context, redisClient *redis.Client, prefix string, channel string, log *zap.Logger) (*NotionalCache, error) {
if redisClient == nil {
return nil, errors.New("redis client is nil")
}
Expand All @@ -67,7 +67,7 @@ func NewNotionalCache(ctx context.Context, redisClient *redis.Client, channel st
pubSub: pubsub,
channel: channel,
notionalMap: sync.Map{},
prefix: "",
prefix: prefix,
logger: log}, nil
}

Expand Down
5 changes: 5 additions & 0 deletions deploy/analytics/analytics-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ spec:
configMapKeyRef:
name: config
key: redis-uri
- name: CACHE_PREFIX
valueFrom:
configMapKeyRef:
name: config
key: redis-prefix
resources:
limits:
memory: {{ .RESOURCES_LIMITS_MEMORY }}
Expand Down
4 changes: 2 additions & 2 deletions deploy/api/api-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ spec:
valueFrom:
configMapKeyRef:
name: config
key: redis-uri
key: redis-prefix
- name: WORMSCAN_DB_URL
valueFrom:
secretKeyRef:
Expand All @@ -89,7 +89,7 @@ spec:
valueFrom:
configMapKeyRef:
name: config
key: redis-uri
key: redis-prefix
- name: WORMSCAN_CACHE_ENABLED
value: "true"
- name: WORMSCAN_CACHE_CHANNEL
Expand Down
3 changes: 2 additions & 1 deletion deploy/common/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ data:
influxdb-organization: {{ .INFLUX_ORGANIZATION }}
influxdb-bucket-infinite: {{ .INFLUX_BUCKET_INFINITE }}
influxdb-bucket-30-days: {{ .INFLUX_BUCKET_30_DAYS }}
influxdb-bucket-24-hours: {{ .INFLUX_BUCKET_24_HOURS }}
influxdb-bucket-24-hours: {{ .INFLUX_BUCKET_24_HOURS }}
influx-bucket: {{ .INFLUX_BUCKET }}

0 comments on commit 78bd0cb

Please sign in to comment.