Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1705] Enhance error-handling in scorecards to prevent updating cache when an error occurs. #1708

Merged
merged 3 commits into from
Sep 18, 2024
Merged

[1705] Enhance error-handling in scorecards to prevent updating cache when an error occurs. #1708

merged 3 commits into from
Sep 18, 2024

Conversation

marianososto
Copy link
Collaborator

@marianososto marianososto commented Sep 18, 2024 •
edited
Loading

  • Ticket: Fix endpoints returning empty when data is updated. #1705
  • Changes on /scorecards endpoints:
    • Error handling:
      • All the errors are collected and returned. This prevents updating the cache with a corrupted value.
      • if one of the queries to the db fails, it cancels the ctx and it signals the rest of the goroutines.
  • Unit-tests: added test-cases to check that the errors are returned.

@marianososto marianososto self-assigned this Sep 18, 2024
@marianososto marianososto marked this pull request as ready for review September 18, 2024 16:12
@marianososto marianososto merged commit 2b778f1 into main Sep 18, 2024
2 checks passed
@marianososto marianososto deleted the fix-scorecards branch September 18, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftocal ftocal ftocal approved these changes

@walker-16 walker-16 walker-16 approved these changes

Assignees

@marianososto marianososto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marianososto @walker-16 @ftocal