Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent failure in x-chain-activity endpoint #420

Conversation

ftocal
Copy link
Collaborator

@ftocal ftocal commented Jun 16, 2023

Replace start_time and end_time query parameters with fixed ranges at the endpoint of the chain activity
Add InfluxDB tasks for enpdoint chain-activity for each timeSpan
Add cache for chain-activity endpoint

@ftocal ftocal requested a review from walker-16 June 16, 2023 15:33
@ftocal ftocal force-pushed the 394-qa-apiv1x-chain-activity-intermittent-failure-to-request-data-from-a-specific-date-to-the-present-1 branch from e72faf5 to 954965f Compare June 16, 2023 15:45
walker-16
walker-16 previously approved these changes Jun 16, 2023
@ftocal ftocal requested review from gipsh and agodnic June 16, 2023 18:31
agodnic
agodnic previously approved these changes Jun 16, 2023
Copy link
Contributor

@agodnic agodnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I've found a couple of minor nitpicks but that's up to you

@ftocal ftocal dismissed stale reviews from agodnic and walker-16 via b3cb596 June 16, 2023 20:40
@ftocal ftocal requested review from walker-16 and agodnic June 16, 2023 20:41
walker-16
walker-16 previously approved these changes Jun 16, 2023
agodnic
agodnic previously approved these changes Jun 16, 2023
… the endpoint of the chain activity

Add InfluxDB tasks for enpdoint chain-activity for each timeSpan
Add cache for chain-activity endpoint
@ftocal ftocal dismissed stale reviews from agodnic and walker-16 via c72376a June 20, 2023 13:18
@ftocal ftocal force-pushed the 394-qa-apiv1x-chain-activity-intermittent-failure-to-request-data-from-a-specific-date-to-the-present-1 branch from b3cb596 to c72376a Compare June 20, 2023 13:18
@ftocal ftocal requested review from walker-16 and agodnic June 20, 2023 13:21
@ftocal ftocal merged commit 69885ae into main Jun 20, 2023
@ftocal ftocal deleted the 394-qa-apiv1x-chain-activity-intermittent-failure-to-request-data-from-a-specific-date-to-the-present-1 branch June 20, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] api/v1/x-chain-activity intermittent failure to request data from a specific date to the present
3 participants