-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intermittent failure in x-chain-activity endpoint #420
Merged
ftocal
merged 2 commits into
main
from
394-qa-apiv1x-chain-activity-intermittent-failure-to-request-data-from-a-specific-date-to-the-present-1
Jun 20, 2023
Merged
Fix intermittent failure in x-chain-activity endpoint #420
ftocal
merged 2 commits into
main
from
394-qa-apiv1x-chain-activity-intermittent-failure-to-request-data-from-a-specific-date-to-the-present-1
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftocal
force-pushed
the
394-qa-apiv1x-chain-activity-intermittent-failure-to-request-data-from-a-specific-date-to-the-present-1
branch
from
June 16, 2023 15:45
e72faf5
to
954965f
Compare
walker-16
previously approved these changes
Jun 16, 2023
agodnic
reviewed
Jun 16, 2023
agodnic
reviewed
Jun 16, 2023
agodnic
reviewed
Jun 16, 2023
agodnic
previously approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I've found a couple of minor nitpicks but that's up to you
walker-16
previously approved these changes
Jun 16, 2023
agodnic
previously approved these changes
Jun 16, 2023
… the endpoint of the chain activity Add InfluxDB tasks for enpdoint chain-activity for each timeSpan Add cache for chain-activity endpoint
ftocal
force-pushed
the
394-qa-apiv1x-chain-activity-intermittent-failure-to-request-data-from-a-specific-date-to-the-present-1
branch
from
June 20, 2023 13:18
b3cb596
to
c72376a
Compare
agodnic
approved these changes
Jun 20, 2023
walker-16
approved these changes
Jun 20, 2023
ftocal
deleted the
394-qa-apiv1x-chain-activity-intermittent-failure-to-request-data-from-a-specific-date-to-the-present-1
branch
June 20, 2023 13:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace start_time and end_time query parameters with fixed ranges at the endpoint of the chain activity
Add InfluxDB tasks for enpdoint chain-activity for each timeSpan
Add cache for chain-activity endpoint