Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

514 modify parser to support new vaa payload parser response #521

Merged
merged 1 commit into from
Jul 12, 2023
Merged

514 modify parser to support new vaa payload parser response #521

merged 1 commit into from
Jul 12, 2023

Conversation

walker-16
Copy link
Collaborator

No description provided.

@walker-16 walker-16 linked an issue Jul 7, 2023 that may be closed by this pull request
Modify parser to support new vaa payload parser response #514
Closed
@walker-16 walker-16 force-pushed the 514-modify-parser-to-support-new-vaa-payload-parser-response branch from 222871d to 193599f Compare July 10, 2023 16:24
agodnic
agodnic reviewed Jul 10, 2023
View reviewed changes
parser/parser/model.go Outdated Show resolved Hide resolved
@ftocal ftocal force-pushed the 514-modify-parser-to-support-new-vaa-payload-parser-response branch 4 times, most recently from 60c47ec to f262c3a Compare July 11, 2023 19:47
@ftocal ftocal marked this pull request as ready for review July 11, 2023 19:47
@ftocal ftocal requested review from ftocal and agodnic July 11, 2023 19:48
agodnic
agodnic suggested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@agodnic agodnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not add this file to version control parser/cmd/__debug_bin

@ftocal @walker-16
Parse amount from metadata fields
37ef475 
Modify parser client to ParseWithMetadata
Add support to new vaa payload parser parse endpoint

Co-authored-by: walker-16 <agpazos85@gmail.com>
@ftocal ftocal force-pushed the 514-modify-parser-to-support-new-vaa-payload-parser-response branch from f262c3a to 37ef475 Compare July 12, 2023 15:09
@ftocal ftocal merged commit 4f1987c into main Jul 12, 2023
1 check passed
@ftocal ftocal deleted the 514-modify-parser-to-support-new-vaa-payload-parser-response branch July 12, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftocal ftocal ftocal approved these changes

@agodnic agodnic agodnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify parser to support new vaa payload parser response
3 participants
@walker-16 @ftocal @agodnic