Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add EVM event-watcher support with mongodb / sns #638

Merged
merged 5 commits into from
Aug 18, 2023
Merged

feat: add EVM event-watcher support with mongodb / sns #638

merged 5 commits into from
Aug 18, 2023

Conversation

raop155
Copy link
Contributor

@raop155 raop155 commented Aug 15, 2023 •
edited
Loading

Description

  • Add EVMWatcher support to store tx logs (VAAs) into MongoDB collection and publish to AWS SNS.

@raop155 raop155 requested a review from gipsh August 15, 2023 17:51
@agodnic
Copy link
Contributor

agodnic commented Aug 16, 2023

Looks good to me!

@raop155 raop155 requested a review from agodnic August 16, 2023 17:38
@raop155 raop155 changed the title feat: add EVM event-watcher support with mongodb feat: add EVM event-watcher support with mongodb / sns Aug 16, 2023
gipsh
gipsh approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@gipsh gipsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!
Dont target only EVM. Include also non evm chains, you already have the watchers.

gipsh
gipsh approved these changes Aug 17, 2023
View reviewed changes
event-watcher/src/databases/types.ts Show resolved Hide resolved
@raop155
Copy link
Contributor Author

raop155 commented Aug 18, 2023 •
edited
Loading

Looks good!! Dont target only EVM. Include also non evm chains, you already have the watchers.

@gipsh Yeah, Im currently doing some cleaning and refactor then I will tackle one by one (other blockchains)

@raop155 raop155 merged commit 64dc83e into main Aug 18, 2023
1 check passed
@raop155 raop155 deleted the feat/event-watcher-evm branch August 18, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gipsh gipsh gipsh approved these changes

@walker-16 walker-16 Awaiting requested review from walker-16

@ftocal ftocal Awaiting requested review from ftocal

@agodnic agodnic Awaiting requested review from agodnic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raop155 @agodnic @gipsh