amount.display: Don't add trailing zeros by default (#696)

* don't add trailing zeros by default * put padEnd back * fix test
wormhole-foundation · Sep 13, 2024 · d61cc30 · d61cc30
1 parent cc51d7c
commit d61cc30
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/core/base/__tests__/amount.ts b/core/base/__tests__/amount.ts
@@ -79,7 +79,7 @@ describe("Amount Tests", function () {
     [{ amount: "1", decimals: 18 }, 20, "0.00000000000000000100"],
     [{ amount: "5020", decimals: 2 }, 0, "50.2"],
     [{ amount: "5020", decimals: 2 }, 4, "50.2000"],
-    [{ amount: "5020", decimals: 2 }, undefined, "50.20"],
+    [{ amount: "5020", decimals: 2 }, undefined, "50.2"],
     [{ amount: "1", decimals: 0 }, 0, "1"],
   ];
 

diff --git a/core/base/src/utils/amount.ts b/core/base/src/utils/amount.ts
@@ -157,6 +157,10 @@ export function display(amount: Amount, precision?: number): string {
       partial = partial.substring(0, partial.length - 1);
     }
     partial = partial.padEnd(precision, "0");
+  } else {
+    // If no specific precision is given, just trim trailing zeroes
+    // and return all significant digits.
+    partial = partial.replace(/0+$/, '');
   }
 
   return partial.length > 0 ? `${whole}.${partial}` : whole;