sui: getCoinType native token address fix (#734)

* sui: getCoinType native token address fix Fixes #730 * change error msg
wormhole-foundation · Nov 8, 2024 · d847b4d · d847b4d
1 parent 9396746
commit d847b4d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/platforms/sui/__tests__/unit/address.test.ts b/platforms/sui/__tests__/unit/address.test.ts
@@ -9,11 +9,26 @@ describe("Sui Address Tests", () => {
       expect(address.toString()).toEqual(
         "0x0000000000000000000000000000000000000000000000000000000000000002::sui::SUI",
       );
+      expect(address.getCoinType()).toEqual(SUI_COIN);
 
       const acctAddress = "0xc90949fd7ff3c13fd0b586a10547b5ca1212edc2c170e368d1dea00c01fea62b";
       address = new SuiAddress(acctAddress);
       expect(address).toBeTruthy();
       expect(address.toString()).toEqual(acctAddress);
+
+      const wrappedTokenAddress =
+        "0x5d4b302506645c37ff133b98c4b50a5ae14841659738d6d733d59d0d217a93bf::coin::COIN";
+      address = new SuiAddress(wrappedTokenAddress);
+      expect(address).toBeTruthy();
+      expect(address.toString()).toEqual(wrappedTokenAddress);
+      expect(address.getCoinType()).toEqual(wrappedTokenAddress);
+
+      const nativeTokenAddress =
+        "0xfa7ac3951fdca92c5200d468d31a365eb03b2be9936fde615e69f0c1274ad3a0::BLUB::BLUB";
+      address = new SuiAddress(nativeTokenAddress);
+      expect(address).toBeTruthy();
+      expect(address.toString()).toEqual(nativeTokenAddress);
+      expect(address.getCoinType()).toEqual(nativeTokenAddress);
     });
 
     test("An invalid address is rejected", () => {

diff --git a/platforms/sui/src/address.ts b/platforms/sui/src/address.ts
@@ -113,7 +113,12 @@ export class SuiAddress implements Address {
     if (this.module === "sui::SUI") {
       return SUI_COIN;
     }
-    return [this.getPackageId(), "coin", "COIN"].join(SUI_SEPARATOR);
+
+    if (!this.module) {
+      throw new Error("No module present in Sui token address");
+    }
+
+    return this.unwrap();
   }
 
   static instanceof(address: any): address is SuiAddress {