tokenBridge protocol: add token address conversion methods #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kev1n-peters
commented
Jul 31, 2024
•
kev1n-peters
commented
- Added getTokenUniversalAddress and getTokenNativeAddress methods to each platform's token bridge protocol implementation.
- Some chains like Aptos and Sui require fetching on-chain data for token address conversions (universal to native and vice versa).
- Fixed issue where lookupDestinationToken would return a universal address, causing issues in functions expecting a native address.
- lookupDestinationToken now consistently returns a native address.
- Resolved issues with transferring native Sui and Aptos tokens back to their origin chains.
kev1n-peters
force-pushed
the
tb-token-addy-fixes
branch
2 times, most recently
from
b89b671
to
57abd71
Compare
- Added getTokenUniversalAddress and getTokenNativeAddress methods to each platform's token bridge protocol implementation. - Some chains like Aptos and Sui require fetching on-chain data for token address conversions (universal to native and vice versa). - Fixed issue where lookupDestinationToken would return a universal address, causing issues in functions expecting a native address. - lookupDestinationToken now consistently returns a native address. - Resolved issues with transferring native Sui and Aptos tokens back to their origin chains.
kev1n-peters
force-pushed
the
tb-token-addy-fixes
branch
from
57abd71
to
4d01fbb
Compare
emreboga
reviewed
Aug 6, 2024
emreboga
reviewed
Aug 6, 2024
emreboga
reviewed
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.