Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isAvailable method from Route interface #687

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove isAvailable method from Route interface #687

wants to merge 1 commit into from

Conversation

artursapek
Copy link
Collaborator

No description provided.

@kev1n-peters kev1n-peters self-requested a review September 6, 2024 16:01
@kev1n-peters
Copy link
Contributor

Looking at the NTT SDK:
https://github.com/wormhole-foundation/example-native-token-transfers/blob/3c626bd7bd8b430d62b4273b75c5729bdc85ddfe/sdk/route/src/automatic.ts#L100-L111

It seems like this logic should be moved into the isProtocolSupported method? The only issue is that we'd have to make that method async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kev1n-peters kev1n-peters Awaiting requested review from kev1n-peters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artursapek @kev1n-peters