Include Spl Token 2022 in getBalances #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solanoepalacio
approved these changes
Oct 28, 2024
artursapek
approved these changes
Oct 29, 2024
solanoepalacio
approved these changes
Oct 29, 2024
|
@artursapek @nonergodic could you merge this one when possible? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LibertAI token NTT integration we saw this bug in Solana token selector:
It shows as disabled when I have a balance in my wallet. It happens because the LibertAI token uses the program spl token 2022, and the SDK only queries the spl token program https://github.com/wormhole-foundation/wormhole-sdk-ts/blob/main/platforms/solana/src/platform.ts#L153-L158.
The solution we found is to include request with the spl token 2022 program id https://github.com/solana-labs/solana-program-library/blob/master/token/js/src/constants.ts#L7