node: (cleanup) remove injectC in favor of using msgC directly #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbjump
requested review from
bruce-riley,
evan-gray and
hendrikhofstadt
as code owners
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
tbjump
force-pushed
the
tbjump/noInjectC
branch
from
37e1da2
to
af7e872
Compare
tbjump
force-pushed
the
tbjump/noInjectC
branch
from
af7e872
to
a136949
Compare
tbjump
force-pushed
the
tbjump/noInjectC
branch
from
a136949
to
1dedbb6
Compare
bruce-riley
previously approved these changes
Aug 21, 2023
tbjump
force-pushed
the
tbjump/noInjectC
branch
from
1dedbb6
to
9fa3a64
Compare
|
Resolved merge conflicts. |
bruce-riley
force-pushed
the
tbjump/noInjectC
branch
from
9fa3a64
to
7cda636
Compare
bruce-riley
approved these changes
Aug 25, 2023
panoel
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place injected governance messages into msgC directly instead of having a separate codepath for governance messages.
Note that this change necessitates moving a defense-in-depth security check from processor/message.go to node/options.go. The check is to prevent watchers from emitting governance messages and I think it makes sense for it to be located with the other checks for watcher messages.