-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evm/deploy automatic relayer mainnet #3266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Ah - to fix the Tilt error, I believe the CI addresses just need to change (probably they are affected by the 'paris' change?) |
c9e4641
to
a03520b
Compare
Yeah, we probably need to expire the cache, but that would cause CI failures for other PRs until everyone's synchronized. I'm not sure there is a way around that though 🤔 |
Hey @scnale @derpy-duck, sorry for jumping over here, but I think I'm facing a similar error related to CI addresses on #3229 I'm injecting some addresses as In particular, here is where I'm injecting them ( May this be affecting the If so, is there any workaround to isolate them? For more context, here is my failing CI job -> https://github.com/wormhole-foundation/wormhole/actions/runs/5782751912/job/15750559917 Thanks! |
Hey there @AlberErre I'll try to explain what I was talking about when I said that we have a cache problem that could impact others: We currently build the automatic relayer contracts with forge in the CI. However, to do so with the particular target EVM version of That said, we didn't take any action yet, I think. So I think this particular issue should not impact other branches just yet. There should only be an impact once we merge to main, if any. I'm not sure if your issue is caused by a cached layer too but it could be 🤔 |
15cfbdd
to
565d614
Compare
b17540b
to
052fefb
Compare
052fefb
to
e5751e6
Compare
@@ -2,53 +2,35 @@ | |||
"addresses": [ | |||
{ | |||
"chainId": 6, | |||
"rewardAddress": "0x61a51662f0B30Bf176484cAc5B4a033C497cB2f3", | |||
"approvedSenders": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what were this approvedSenders
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an ancient version of the AR, you could actually designate relayer accounts and only those would be able to relay on behalf of the specific delivery provider. That has since been removed. I'm not sure why it was implemented in the first place since relayer fee payments are finalized in the source chain rather than the destination chain so MEV, front running and oracle copying of relays is not a concern.
e5751e6
to
023dbc0
Compare
023dbc0
to
28e4afe
Compare
- Actually uses operating chains instead of chains. - Avoids setting obsolete configuration option for the wormhole relayer address.
When adding a new chain, old and new deployments are merged before being written to JSON files.
This lets you verify `Create2Factory` and `DeliveryProvider` contracts.
…actory. Performing this calculation requires us to know the deployer of the wormhole relayer contract. This could vary in the current deployment scheme. Thus, we rely on the recorded wormhole relayer address instead.
…strations that haven't been done yet for wormhole relayer
0f33af5
to
bec5810
Compare
Closing as @solanoepalacio mentioned this was superseded by #3522 |
This contains the deployment configuration and build pipeline used to deploy the automatic relayers on mainnet across 10 chains:
It also adds a verification script for the
DeliveryProvider
and theWormholeRelayer
contracts.