Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evm/deploy automatic relayer mainnet #3266

Closed
wants to merge 34 commits into from

Conversation

scnale
Copy link
Collaborator

@scnale scnale commented Aug 4, 2023

This contains the deployment configuration and build pipeline used to deploy the automatic relayers on mainnet across 10 chains:

  • Ethereum
  • BSC
  • Polygon
  • Avalanche
  • Fantom
  • Klaytn
  • Celo
  • Moonbeam
  • Arbitrum
  • Optimism

It also adds a verification script for the DeliveryProvider and the WormholeRelayer contracts.

derpy-duck
derpy-duck previously approved these changes Aug 4, 2023
Copy link
Contributor

@derpy-duck derpy-duck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@derpy-duck
Copy link
Contributor

Ah - to fix the Tilt error, I believe the CI addresses just need to change (probably they are affected by the 'paris' change?)

@derpy-duck derpy-duck force-pushed the evm/deploy-generic-relayer-mainnet branch from c9e4641 to a03520b Compare August 5, 2023 20:53
@scnale
Copy link
Collaborator Author

scnale commented Aug 5, 2023

Yeah, we probably need to expire the cache, but that would cause CI failures for other PRs until everyone's synchronized. I'm not sure there is a way around that though 🤔

@AlberErre
Copy link
Contributor

AlberErre commented Aug 10, 2023

Hey @scnale @derpy-duck, sorry for jumping over here, but I think I'm facing a similar error related to CI addresses on #3229

I'm injecting some addresses as env variables due to testing purposes.

In particular, here is where I'm injecting them (clients/js/__tests__/utils/env/worm-submit/wormSubmitCliEnv.cjs) -> https://github.com/wormhole-foundation/wormhole/pull/3229/files#diff-d4ec4f0c385c109e39e166266f9298abcd837f2957e00e74bc6ab3632c2bdc7c

May this be affecting the env variables used on the tilt ci job? 👀

If so, is there any workaround to isolate them?

For more context, here is my failing CI job -> https://github.com/wormhole-foundation/wormhole/actions/runs/5782751912/job/15750559917

Thanks!

@scnale
Copy link
Collaborator Author

scnale commented Aug 12, 2023

Hey there @AlberErre I'll try to explain what I was talking about when I said that we have a cache problem that could impact others:

We currently build the automatic relayer contracts with forge in the CI. However, to do so with the particular target EVM version of paris we need a newer forge version than what is installed in the cached layers of the images that build these contracts.

That said, we didn't take any action yet, I think. So I think this particular issue should not impact other branches just yet. There should only be an impact once we merge to main, if any.

I'm not sure if your issue is caused by a cached layer too but it could be 🤔
I'm not that familiar with the whole slew of images defined in the tiltfile :P

@scnale scnale force-pushed the evm/deploy-generic-relayer-mainnet branch 2 times, most recently from 15cfbdd to 565d614 Compare August 12, 2023 04:01
@derpy-duck derpy-duck self-requested a review August 23, 2023 21:06
derpy-duck
derpy-duck previously approved these changes Aug 23, 2023
@@ -2,53 +2,35 @@
"addresses": [
{
"chainId": 6,
"rewardAddress": "0x61a51662f0B30Bf176484cAc5B4a033C497cB2f3",
"approvedSenders": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what were this approvedSenders?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an ancient version of the AR, you could actually designate relayer accounts and only those would be able to relay on behalf of the specific delivery provider. That has since been removed. I'm not sure why it was implemented in the first place since relayer fee payments are finalized in the source chain rather than the destination chain so MEV, front running and oracle copying of relays is not a concern.

@scnale scnale force-pushed the evm/deploy-generic-relayer-mainnet branch from e5751e6 to 023dbc0 Compare October 5, 2023 16:50
@scnale scnale force-pushed the evm/deploy-generic-relayer-mainnet branch from 023dbc0 to 28e4afe Compare October 20, 2023 16:23
@evan-gray evan-gray added the evm label Mar 14, 2024
scnale and others added 25 commits March 17, 2024 09:17
- Actually uses operating chains instead of chains.
- Avoids setting obsolete configuration option for the wormhole relayer
  address.
When adding a new chain, old and new deployments are merged before being
written to JSON files.
This lets you verify `Create2Factory` and `DeliveryProvider` contracts.
…actory.

Performing this calculation requires us to know the deployer of the
wormhole relayer contract. This could vary in the current deployment
scheme. Thus, we rely on the recorded wormhole relayer address instead.
…strations that haven't been done yet for wormhole relayer
@evan-gray evan-gray force-pushed the evm/deploy-generic-relayer-mainnet branch from 0f33af5 to bec5810 Compare March 17, 2024 13:17
@scnale scnale requested a review from nonergodic as a code owner March 17, 2024 13:17
@evan-gray
Copy link
Contributor

evan-gray commented Mar 27, 2024

Closing as @solanoepalacio mentioned this was superseded by #3522

@evan-gray evan-gray closed this Mar 27, 2024
@scnale scnale deleted the evm/deploy-generic-relayer-mainnet branch May 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants